fix(player): Fixed typo and added workflow to just update captions wh…

…en track with same srclang and kind existed previously
openplayerjs · Dec 14, 2018 · 0bab31e · 0bab31e
1 parent 712311a
commit 0bab31e
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 17 deletions.
diff --git a/dist/openplayer.js b/dist/openplayer.js
@@ -1518,21 +1518,30 @@ var Player = function () {
     key: "addCaptions",
     value: function addCaptions(args) {
       if (args.default) {
-        var tracks = this.element.querySelectorAll('tracks');
+        var tracks = this.element.querySelectorAll('track');
 
         for (var i = 0, total = tracks.length; i < total; i++) {
           tracks[i].default = false;
         }
       }
 
       var el = this.element;
-      var track = document.createElement('track');
-      track.srclang = args.srclang;
-      track.src = args.src;
-      track.kind = args.kind;
-      track.label = args.label;
-      track.default = args.default || null;
-      this.element.appendChild(track);
+      var track = el.querySelector("track[srclang=\"".concat(args.srclang, "\"][kind=\"").concat(args.kind, "\"]"));
+
+      if (track) {
+        track.src = args.src;
+        track.label = args.label;
+        track.default = args.default || null;
+      } else {
+        track = document.createElement('track');
+        track.srclang = args.srclang;
+        track.src = args.src;
+        track.kind = args.kind;
+        track.label = args.label;
+        track.default = args.default || null;
+        el.appendChild(track);
+      }
+
       var e = events_1.addEvent('controlschanged');
       el.dispatchEvent(e);
     }

diff --git a/dist/openplayer.min.js b/dist/openplayer.min.js
diff --git a/src/js/player.ts b/src/js/player.ts
@@ -489,20 +489,29 @@ class Player {
      */
     public addCaptions(args: Track): void {
         if (args.default) {
-            const tracks = this.element.querySelectorAll('tracks');
+            const tracks = this.element.querySelectorAll('track');
             for (let i = 0, total = tracks.length; i < total; i++) {
                 (tracks[i] as HTMLTrackElement).default = false;
             }
         }
 
         const el = this.element;
-        const track = document.createElement('track');
-        track.srclang = args.srclang;
-        track.src = args.src;
-        track.kind = args.kind;
-        track.label = args.label;
-        track.default = args.default || null;
-        this.element.appendChild(track);
+
+        // If captions have been added previously, just update URL and default status
+        let track = (el.querySelector(`track[srclang="${args.srclang}"][kind="${args.kind}"]`) as HTMLTrackElement);
+        if (track) {
+            track.src = args.src;
+            track.label = args.label;
+            track.default = args.default || null;
+        } else {
+            track = document.createElement('track');
+            track.srclang = args.srclang;
+            track.src = args.src;
+            track.kind = args.kind;
+            track.label = args.label;
+            track.default = args.default || null;
+            el.appendChild(track);
+        }
 
         const e = addEvent('controlschanged');
         el.dispatchEvent(e);