fix(player): Removed conditional to create controls on iPhone as well…

…, and added negative `z-index` in Ads container when inactive
openplayerjs · May 1, 2018 · 1aca10e · 1aca10e
1 parent ee57974
commit 1aca10e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/css/player.css b/src/css/player.css
@@ -651,11 +651,14 @@ video:-webkit-media-text-track-display {
     position: absolute;
     top: 0;
     width: 100%;
-    z-index: 1;
+    z-index: -1;
 }
 .om-ads--active {
     overflow: hidden;
 }
+.om-ads--active #om-ads {
+    z-index: 1;
+}
 .om-player[data-fullscreen='true'] #om-ads {
     z-index: 2147483647;
 }

diff --git a/src/js/player.ts b/src/js/player.ts
@@ -6,7 +6,7 @@ import PlayerInstanceList from './interfaces/instance';
 import Source from './interfaces/source';
 import Media from './media';
 import Ads from './media/ads';
-import { IS_ANDROID, IS_FIREFOX, IS_IOS, IS_IPHONE } from './utils/constants';
+import { IS_ANDROID, IS_FIREFOX, IS_IOS } from './utils/constants';
 import { addEvent } from './utils/events';
 import { isAudio, isVideo } from './utils/general';
 import { isAutoplaySupported } from './utils/media';
@@ -220,10 +220,7 @@ class Player {
             this._wrapInstance();
             this._createPlayButton();
             this._createUID();
-
-            if (!IS_IPHONE && isVideo) {
-                this._createControls();
-            }
+            this._createControls();
             this._setEvents();
             this._autoplay();
             Player.instances[this.id] = this;