fix(player): Removed unnecessary event workflow and added loader stat…

…e in `loadedmetadata` event
openplayerjs · Dec 3, 2018 · 2f6c03c · 2f6c03c
1 parent 753ae76
commit 2f6c03c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 14 deletions.
diff --git a/dist/openplayer.js b/dist/openplayer.js
@@ -1670,6 +1670,8 @@ var Player = function () {
         this.events.loadedmetadata = function () {
           var el = _this3.activeElement();
 
+          _this3.loader.setAttribute('aria-hidden', 'true');
+
           if (el.paused) {
             _this3.playBtn.classList.remove('op-player__play--paused');
 
@@ -1685,14 +1687,6 @@ var Player = function () {
           _this3.loader.setAttribute('aria-hidden', 'false');
         };
 
-        this.events.durationchange = function () {
-          var el = _this3.activeElement();
-
-          _this3.playBtn.setAttribute('aria-hidden', 'true');
-
-          _this3.loader.setAttribute('aria-hidden', el instanceof media_1.default || constants_1.IS_ANDROID || constants_1.IS_IOS ? 'false' : 'true');
-        };
-
         this.events.canplay = function () {
           _this3.playBtn.setAttribute('aria-hidden', 'true');
 

diff --git a/dist/openplayer.min.js b/dist/openplayer.min.js
diff --git a/src/js/player.ts b/src/js/player.ts
@@ -707,6 +707,7 @@ class Player {
         if (isVideo(this.element)) {
             this.events.loadedmetadata = () => {
                 const el = this.activeElement();
+                this.loader.setAttribute('aria-hidden', 'true');
                 if (el.paused) {
                     this.playBtn.classList.remove('op-player__play--paused');
                     this.playBtn.setAttribute('aria-pressed', 'false');
@@ -717,11 +718,6 @@ class Player {
                 this.playBtn.setAttribute('aria-hidden', 'true');
                 this.loader.setAttribute('aria-hidden', 'false');
             };
-            this.events.durationchange = () => {
-                const el = this.activeElement();
-                this.playBtn.setAttribute('aria-hidden', 'true');
-                this.loader.setAttribute('aria-hidden', el instanceof Media || IS_ANDROID || IS_IOS ? 'false' : 'true');
-            };
             this.events.canplay = () => {
                 this.playBtn.setAttribute('aria-hidden', 'true');
                 this.loader.setAttribute('aria-hidden', 'true');