fix(player): Refined workflow to update captions

openplayerjs · Dec 14, 2018 · 37a3e09 · 37a3e09
1 parent 0bab31e
commit 37a3e09
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 23 deletions.
diff --git a/dist/openplayer.js b/dist/openplayer.js
@@ -1529,19 +1529,16 @@ var Player = function () {
       var track = el.querySelector("track[srclang=\"".concat(args.srclang, "\"][kind=\"").concat(args.kind, "\"]"));
 
       if (track) {
-        track.src = args.src;
-        track.label = args.label;
-        track.default = args.default || null;
-      } else {
-        track = document.createElement('track');
-        track.srclang = args.srclang;
-        track.src = args.src;
-        track.kind = args.kind;
-        track.label = args.label;
-        track.default = args.default || null;
-        el.appendChild(track);
+        track.remove();
       }
 
+      track = document.createElement('track');
+      track.srclang = args.srclang;
+      track.src = args.src;
+      track.kind = args.kind;
+      track.label = args.label;
+      track.default = args.default || null;
+      el.appendChild(track);
       var e = events_1.addEvent('controlschanged');
       el.dispatchEvent(e);
     }

diff --git a/dist/openplayer.min.js b/dist/openplayer.min.js
diff --git a/src/js/player.ts b/src/js/player.ts
@@ -500,18 +500,15 @@ class Player {
         // If captions have been added previously, just update URL and default status
         let track = (el.querySelector(`track[srclang="${args.srclang}"][kind="${args.kind}"]`) as HTMLTrackElement);
         if (track) {
-            track.src = args.src;
-            track.label = args.label;
-            track.default = args.default || null;
-        } else {
-            track = document.createElement('track');
-            track.srclang = args.srclang;
-            track.src = args.src;
-            track.kind = args.kind;
-            track.label = args.label;
-            track.default = args.default || null;
-            el.appendChild(track);
+            track.remove();
         }
+        track = document.createElement('track');
+        track.srclang = args.srclang;
+        track.src = args.src;
+        track.kind = args.kind;
+        track.label = args.label;
+        track.default = args.default || null;
+        el.appendChild(track);
 
         const e = addEvent('controlschanged');
         el.dispatchEvent(e);