fix(player): Moved event dispatcher outside of conditional to ensure …

…volume icon is updated accordingly
openplayerjs · Jan 13, 2019 · 5bbf745 · 5bbf745
1 parent bea6320
commit 5bbf745
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/dist/openplayer.js b/dist/openplayer.js
@@ -6350,11 +6350,11 @@ var Volume = function () {
 
         if (el.muted) {
           el.volume = 0;
-          el.muted = true;
-          var e = events_1.addEvent('volumechange');
-
-          _this.player.getElement().dispatchEvent(e);
         }
+
+        var e = events_1.addEvent('volumechange');
+
+        _this.player.getElement().dispatchEvent(e);
       };
 
       this.events.slider.input = updateVolume.bind(this);

diff --git a/dist/openplayer.min.js b/dist/openplayer.min.js
diff --git a/src/js/controls/volume.ts b/src/js/controls/volume.ts
@@ -222,10 +222,9 @@ class Volume implements PlayerComponent {
             const el = this.player.activeElement();
             if (el.muted) {
                 el.volume = 0;
-                el.muted = true;
-                const e = addEvent('volumechange');
-                this.player.getElement().dispatchEvent(e);
             }
+            const e = addEvent('volumechange');
+            this.player.getElement().dispatchEvent(e);
         };
         this.events.slider.input = updateVolume.bind(this);
         this.events.slider.change = updateVolume.bind(this);