fix(player): Formatted time when media has ended and added missing va…

…lidation for it to avoid displaying NaN values
openplayerjs · May 29, 2019 · c4c591e · c4c591e
1 parent d50acf3
commit c4c591e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/dist/openplayer.js b/dist/openplayer.js
@@ -6088,8 +6088,10 @@ var Time = function () {
       this.events.media.ended = function () {
         var el = _this.player.activeElement();
 
-        if (_this.player.isMedia() && _this.duration.innerText !== '0:00') {
-          _this.duration.innerText = time_1.formatTime(el.duration);
+        var duration = !isNaN(el.duration) ? el.duration : 0;
+
+        if (_this.player.isMedia()) {
+          _this.duration.innerText = time_1.formatTime(duration);
         }
       };
 

diff --git a/dist/openplayer.min.js b/dist/openplayer.min.js
diff --git a/src/js/controls/time.ts b/src/js/controls/time.ts
@@ -146,8 +146,9 @@ class Time implements PlayerComponent {
         };
         this.events.media.ended = () => {
             const el = this.player.activeElement();
-            if (this.player.isMedia() && this.duration.innerText !== '0:00') {
-                this.duration.innerText = formatTime(el.duration);
+            const duration = !isNaN(el.duration) ? el.duration : 0;
+            if (this.player.isMedia()) {
+                this.duration.innerText = formatTime(duration);
             }
         };