fix(player): Expanded conditional to allow rendering settings speed b…

…y default
openplayerjs · May 31, 2019 · fe5a271 · fe5a271
1 parent c4c591e
commit fe5a271
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/dist/openplayer.js b/dist/openplayer.js
@@ -4488,7 +4488,9 @@ var Controls = function () {
       });
       Object.keys(this.items).forEach(function (position) {
         _this5.items[position].forEach(function (item) {
-          if (!_this5.player.getOptions().detachMenus && !item.custom && typeof item.addSettings === 'function') {
+          var allowDefault = !_this5.player.getOptions().detachMenus || item instanceof settings_1.default;
+
+          if (allowDefault && !item.custom && typeof item.addSettings === 'function') {
             var menuItem = item.addSettings();
 
             if (Object.keys(menuItem).length) {

diff --git a/dist/openplayer.min.js b/dist/openplayer.min.js
diff --git a/src/js/controls.ts b/src/js/controls.ts
@@ -377,7 +377,8 @@ class Controls implements PlayerComponent {
 
         Object.keys(this.items).forEach((position: string) => {
             this.items[position].forEach((item: any) => {
-                if (!this.player.getOptions().detachMenus && !item.custom && typeof item.addSettings === 'function') {
+                const allowDefault = !this.player.getOptions().detachMenus || item instanceof Settings;
+                if (allowDefault && !item.custom && typeof item.addSettings === 'function') {
                     const menuItem = item.addSettings();
                     if (Object.keys(menuItem).length) {
                         this.settings.addItem(