Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ad: Cannot read property 'getVolume' of null #213

Closed
tigitz opened this issue Mar 7, 2021 · 1 comment
Closed

Ad: Cannot read property 'getVolume' of null #213

tigitz opened this issue Mar 7, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@tigitz
Copy link

tigitz commented Mar 7, 2021 •
edited

Describe the bug
When loading an ad I get this:

TypeError
Cannot read property 'getVolume' of null
Ads.get volume [as volume]
https://tzdyh.csb.app/node_modules/openplayerjs/dist/esm/media/ads.js:187:28
updateSlider
https://tzdyh.csb.app/node_modules/openplayerjs/dist/esm/controls/volume.js:58:35
HTMLAudioElement.events.media.volumechange
https://tzdyh.csb.app/node_modules/openplayerjs/dist/esm/controls/volume.js:93:7
HTMLAudioElement.events.media.loadedmetadata
https://tzdyh.csb.app/node_modules/openplayerjs/dist/esm/controls/volume.js:107:32

To Reproduce
https://codesandbox.io/s/epic-meitner-tzdyh?file=/src/index.ts:169-409
@tigitz tigitz mentioned this issue Mar 7, 2021
Closed
@rafa8626 rafa8626 added the bug Something isn't working label Mar 7, 2021
@rafa8626
Copy link
Member

rafa8626 commented Mar 7, 2021

@tigitz please download the master branch and let me know if it's solved for you. I tested with the CodePen your provided and also #214 was fixed with this

@rafa8626 rafa8626 mentioned this issue Mar 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rafa8626 @tigitz