Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Variadic to Variant #78

Closed
C0nsultant opened this issue Feb 17, 2018 · 1 comment
Closed

Rename Variadic to Variant #78

C0nsultant opened this issue Feb 17, 2018 · 1 comment

Comments

@C0nsultant
Copy link
Member

The generic storage used for e.g. Attribute values was initially designed to store arbitrary datatypes, hence the name Variadic was chosen.

During developement it became pretty obvious that a restriction to a finite, predefined set of datatypes is the more sensible way. Since boost/mpark/std variants do exactly that, they have been used all along.

I propose to rename the auxiliary class Variadic to Variant to reflect this decision.

@C0nsultant C0nsultant self-assigned this Feb 17, 2018
@C0nsultant C0nsultant changed the title Rename Varaidic to Variant Rename Variadic to Variant Feb 17, 2018
@ax3l
Copy link
Member

ax3l commented Feb 18, 2018

Agreed!

@ax3l ax3l removed the discussion label Feb 18, 2018
@ax3l ax3l added this to To do in First Stable Release Feb 20, 2018
@C0nsultant C0nsultant moved this from To do to In progress in First Stable Release Apr 11, 2018
First Stable Release automation moved this from In progress to Done Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants