Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Note element text is not shown immediately #90

Closed
sdasda7777 opened this issue Jan 25, 2023 · 3 comments · Fixed by #92
Closed

[Bug] Note element text is not shown immediately #90

sdasda7777 opened this issue Jan 25, 2023 · 3 comments · Fixed by #92

Comments

@sdasda7777
Copy link
Contributor

I've noticed that when creating new Note element, the text only appears after clicking somewhere or moving the camera. Most likely there should be some update call happening right after creation and it isn't.

On the following picture, both elements have text, only for the second one it isn't shown yet.

image

@sdasda7777
Copy link
Contributor Author

Manually calling renderFigureIn: after updating the text seems to fix it, but I'm not sure if it is the correct solution.

image

@JanBliznicenko
Copy link
Member

Well, I actually do not like have anything figure-related in this method at all, but that is story for another day :)
For now, I think best solution would be to put text signalUpdate to the end of OPResizableFigureWithText>>#updateText. Sending signalUpdate to roassal element causes canvas to redraw and that is needed exactly when we update the text.

@sdasda7777
Copy link
Contributor Author

That is definitely much more elegant, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants