Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pkt.Compact #107

Closed
EthanHeilman opened this issue Feb 27, 2024 · 1 comment
Closed

Remove pkt.Compact #107

EthanHeilman opened this issue Feb 27, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@EthanHeilman
Copy link
Member

As discussed in #105 Fixes JWS signing bug where we JSON unmarshalling breaks verification, the function pkt.Compact is intended to produce compact tokens that can pass signature verification. #105 makes pkt.Compact safe to use by just having it pull the corresponding saved token from the PK Token struct. This makes pkt.Compact redundant the developer could just pull the saved token themselves in fewer lines of code.

pkt.Compact, developers should simply use the compact token saved to the PK Token.
Rather than:

cicToken, err := pkt.Compact(pkt.Cic)

do this instead:

cicToken := pkt.CicToken

This issue should be resolved when we create a PR to remove pkt.Compact from the PK Token and from the examples. It depeneds on #105 being merged first.

@EthanHeilman
Copy link
Member Author

pkt.Compact was removed in #110 closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant