Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix find_package(qasm <...>) #6

Open
vrpascuzzi opened this issue Dec 10, 2022 · 1 comment
Open

Fix find_package(qasm <...>) #6

vrpascuzzi opened this issue Dec 10, 2022 · 1 comment

Comments

@vrpascuzzi
Copy link
Contributor

vrpascuzzi commented Dec 10, 2022

We should have a coherent naming convention for the QASM library:
https://github.com/Qiskit/qss-compiler/blob/main/CMakeLists.txt#L43
and
https://github.ibm.com/IBM-Q-Software/qss-qasm/blob/master/CMakeLists.txt#L170-L180

I propose the following options:
(a) qss-compiler adheres to qss-qasm naming, i.e.,
find_package(qasm REQUIRED) -> find_package(OpenQASM REQUIRED); or
(b) qss-qasm adheres to qss-compiler, namely,
OpenQASMConfig.cmake -> qasmConfig.cmake
OpenQASMConfigVersion.cmake -> qasmConfigVersion.cmake

I'm, in a sense, torn between the options, but believe that we should go with (a), i.e., qss-compiler (and thusly Conan) conformance to qss-qasm conventions, esp. if qss-qasm will be open sourced.

In general, coherence is needed to prevent divergence between build envs/systems for all developers/users.

@taalexander
Copy link
Collaborator

Has this been resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants