-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stomp.py version changes #7
Comments
Are you able to submit a PR? |
Which approach would you prefer? I note there's no dependency versioning given in the repo at present, which leaves open the potential for similar regressions in future. |
A PR which locks the dependency to the version that the code works with would be the simplest thing to start with - and a PR which uses the latest version with code changes, if you have time, please. But unless there's anything fundamentally better or fixed in the version that deprecates the start() method, the former is a good use of everyone's time |
Version 5 of the library removes python 2 support, which might be a step too far for some. PR just adds the version requirement to the |
As of stomp.py version 5, the
connection.start()
function has been removed. The use of the function in this code should either be removed, or a compatible major version of the stomp.py version specified.The text was updated successfully, but these errors were encountered: