Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart watch on K8S 410 gone instead of restarting the probe #81

Closed
bzurkowski opened this issue May 6, 2020 · 0 comments · Fixed by #84
Closed

Restart watch on K8S 410 gone instead of restarting the probe #81

bzurkowski opened this issue May 6, 2020 · 0 comments · Fixed by #84
Assignees
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@bzurkowski
Copy link
Member

Currently, whenever 410 Gone error received from a watch stream, the ResourceProxy closes the watch and returns:

while True:
    for event in self._watch_resource():
        ...
        if event_type == 'ERROR' and event_obj.code == 410:
            return

Consequently, the probe is restarted.
The proxy should break the watch loop and restart the watch instead.

@bzurkowski bzurkowski added the bug Something isn't working label May 6, 2020
@bzurkowski bzurkowski added this to the 0.2 milestone May 6, 2020
@bzurkowski bzurkowski self-assigned this May 6, 2020
@bzurkowski bzurkowski added the good first issue Good for newcomers label May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant