Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose all NPM options to snippet #354

Closed
Amitabitbul opened this issue Feb 27, 2022 · 4 comments
Closed

Expose all NPM options to snippet #354

Amitabitbul opened this issue Feb 27, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request tracker

Comments

@Amitabitbul
Copy link

Hey guys,

I don't know why but for some reason, the library doesn't capture the iframe.
The iframe wasn't placed on the root document at first, it will be dynamically injected into the document - it depends on the user's actions.

other libraries can capture it easily, I'm sure that it's a small thing/bug that needs to be fixed to allow it here.

@estradino suggested me to open the issue here :)

Thanks!

@Amitabitbul
Copy link
Author

UPDATE:
I played with it a little bit longer, and I find out that it just did not listen to the iframe events correctly.
I haven't fixed it, and for now, I don't know how to.

In my case, I'm injecting an empty HTML page at first and then changing its content, so nothing was captured not the content, and not the events inside (the mouse is out of this area, and it is marked as inactivity in your player)

Steps to re-procedure -> When trying to register the iframe in TopObserver - I've put it in setTimeout function for delaying it for a 10s, so I wanted to know if it just not capturing the view (content) or its something else, for the very first time, I was able to see the iframe content in the session replay without its resources (styling, and more), and the view wasn't changed if I entered to a link.

as I said before, other libraries works, so it's not a TLDs issue (every link is under the same domain)

@estradino
Copy link
Contributor

estradino commented Feb 28, 2022

Hey @Amitabitbul,
We'll be exposing all NPM options in the snippet. That'll fix this issue. ETA: March 11th with the next release.

@estradino estradino changed the title Iframes not captured Expose all NPM options to snippet Feb 28, 2022
@estradino estradino added the enhancement New feature or request label Feb 28, 2022
@estradino
Copy link
Contributor

All NPM options exposed in JS snippet in tracker v3.5.3.

@Amitabitbul
Copy link
Author

You are awesome!
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tracker
Projects
None yet
Development

No branches or pull requests

3 participants