Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCP socket closed #13

Closed
Tieske opened this issue May 19, 2016 · 2 comments
Closed

TCP socket closed #13

Tieske opened this issue May 19, 2016 · 2 comments

Comments

@Tieske
Copy link
Contributor

Tieske commented May 19, 2016

The UDP part can be sequentially used for multiple requests. But the TCP socket is closed upon completion, and hence the second request fails because the socket is closed.

So instead of creating the TCP socket up front (in new, I think it should be created upon actually querying in _tcp_query.

Correct?

@agentzh
Copy link
Member

agentzh commented May 19, 2016

@Tieske I think we can still call tcpsock:new() in resolver.new and just call tcpsock:connect() in _tcp_query. This way we can avoid creating a new TCP cosocket object in every _tcp_query call. What do you think? Patches welcome BTW :)

@Tieske
Copy link
Contributor Author

Tieske commented May 20, 2016

nevermind, I can no longer reproduce what I ran into. So must be an error on my side. Sorry for the noise!

@Tieske Tieske closed this as completed May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants