Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster #43

Open
misiek08 opened this issue May 1, 2014 · 13 comments
Open

Cluster #43

misiek08 opened this issue May 1, 2014 · 13 comments

Comments

@misiek08
Copy link

misiek08 commented May 1, 2014

Hi! Is it possible to implement cluster functionality to core of this library? I'm not sure if I am able to do it myself, I tried, but code looks bad and it fails sometimes.

@agentzh
Copy link
Member

agentzh commented May 1, 2014

@misiek08 I don't have the time to look into this and I'll rely on contributions :)

@misiek08
Copy link
Author

misiek08 commented May 2, 2014

So we need to wait, right? :)

@agentzh
Copy link
Member

agentzh commented May 2, 2014

Yes. I have put this into my TODO list. This is indeed a good thing to have.

@fengpeiyuan
Copy link

come on misiek08 💯

@wbdu
Copy link

wbdu commented Apr 3, 2015

come on

@bjoe2k4
Copy link
Contributor

bjoe2k4 commented Apr 3, 2015

Maybe i'm wrong, but doesn't redis have builtin clustering functionality since version 3.0? Can't we rely on that?

@misiek08
Copy link
Author

misiek08 commented Apr 4, 2015

@bjoe2k4 yes it have, but client need to implement few responses from Redis to fully support cluster. Redis have built in only semi-routing which tells client where to ask for data if client connected to wrong node at first.

@agentzh
Copy link
Member

agentzh commented Apr 4, 2015

Guys, there are two pull requests implementing cluster-related features on the client side. Have you checked them out? See

https://github.com/openresty/lua-resty-redis/pulls

@misiek08
Copy link
Author

misiek08 commented Apr 4, 2015

I see only one is totally cluster-related but I don't understand a part of code there.... Looks like there are 2 hard-coded limits for cluster count (20) and nodes count in cluster (500).
It looks like this pull is using one object for many cluster and I think that one "client" should be one cluster. About node count limit I think it should be done on dynamically sized array if possible.

Or Lua is better than I think and my comment it's useless :) I had half-year break in Lua and nginx-related development...

@bungle
Copy link
Member

bungle commented May 20, 2015

I will add this to here as a reminder that implementing a cluster support is not something that can be done ligthly, many questions needs to be answered, a lot of design decisions need to be made:
redis/jedis#990 (comment)

@alu
Copy link

alu commented Sep 16, 2015

+1

@vkozubal
Copy link

+1

@spacewander
Copy link
Member

Actually there are some unofficial clients offer part of the redis-cluster support. For example, like this one:
https://github.com/steve0511/resty-redis-cluster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants