-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge browser: show edit component based on the invitation spec #374
Comments
it looks like content.label from the edit invitation is not used at all |
If the edit invitation is like the Bid Invitation, then we should read the label. |
the main purpose for now is to support 3 kinds of edit invitations:
the logic to decide the control to render is:
when an EditEdgeToggle is rendered, the label text following the editEdge param in URL should be the label when creating a new edge. if the invitation has only label field and specified value-regex, check if the url has the label, if not ui should render an input to collect label from user. if url has label, it should be used to the label in new edge created. |
let's say we are rendering a dropdown for label and a dropdown for weight and the edit invitation in URL has specified label:some label. when adding an edit edge, should the label be fixed to the label in url or allow selection of label? |
If the label is present in the url then I wouldn’t render the widget and use that value to post all the edges. |
Changes we discussed on today's call:
|
I think i will split the editEdge to two properties: |
Remove the code:
and create the component based on the invitation weight or label spec.
If value-dropdown then use EditEdgeDropdown
If value-radio then implement a widget to render the options as buttons(?) or use a dropdown too.
default should be EditEdgeToggle
The text was updated successfully, but these errors were encountered: