Skip to content
This repository has been archived by the owner on Oct 6, 2021. It is now read-only.

Gradle Wrapper Upgrade should also update shell scripts, gradle-wrapper.jar #1

Open
shanman190 opened this issue Jul 28, 2021 · 1 comment
Labels
enhancement New feature or request
Projects

Comments

@shanman190
Copy link

Often it is the case that there are also gradle and gradlew.bat file changes alongside the wrapper properties file. Sometimes, very rarely, there is also a change to gradle-wrapper.jar. Is there a plan to handle these as well?

At least last I looked at the docs, the suggestion was to effectively run gradlew wrapper --gradle-version=<new_version> twice. The internals are to update the property file and to copy the two scripts and jar from the currently executing Gradle distribution. So in essence, the first pass changes the wrapper properties file and the second pass picks up new changes from the downloaded distribution if there were any.

@sambsnyd sambsnyd added the enhancement New feature or request label Aug 4, 2021
@sambsnyd
Copy link
Member

sambsnyd commented Aug 4, 2021

You are, of course, correct about the jar and shell scripts occasionally changing. We don't have a good way to handle this right now. Will likely revisit this as we bring Groovy and Gradle ASTs online so that we can automate gradle dependency management.

@sambsnyd sambsnyd changed the title Gradle Wrapper Upgrade Gradle Wrapper Upgrade should also update shell scripts, gradle-wrapper.jar Aug 4, 2021
@okundzich okundzich added this to Backlog in Backlog Oct 7, 2021
@okundzich okundzich moved this from Backlog to Icebox in Backlog Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Backlog
  
Icebox
Development

No branches or pull requests

2 participants