Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate WebMvcTags to ServerRequestObservationConvention #531

Open
timtebeek opened this issue May 22, 2024 · 2 comments
Open

Migrate WebMvcTags to ServerRequestObservationConvention #531

timtebeek opened this issue May 22, 2024 · 2 comments
Labels
boot-3.2 recipe Recipe requested

Comments

@timtebeek
Copy link
Contributor

What problem are you trying to solve?

WebMvcTags was deprecated in 3.0, for removal in 3.2 in favor of ServerRequestObservationConvention.
The 3.0 release notes merely mention:

RestTemplateExchangeTagsProvider, WebClientExchangeTagsProvider, WebFluxTagsProvider, WebMvcTagsProvider and related classes have been replaced with ObservationConvention equivalents.

The before/after of this change is still a bit unclear to me; hoping someone can provide additional samples of how this API was used, and how the replacements should look in 3.2+.

@timtebeek timtebeek added recipe Recipe requested boot-3.2 labels May 22, 2024
@bsmahi
Copy link
Contributor

bsmahi commented May 23, 2024

Hi @timtebeek

I could find some more information on this topic

https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0-Migration-Guide#tag-providers-and-contributors-migration

Hope this helps. I will further explore on it.

Thanks,
Mahi

@timtebeek
Copy link
Contributor Author

Thanks for the helpful link @bsmahi ; looks quite involved at first glance, especially as the methods in DefaultServerRequestObservationConvention are non static, whereas WebMvcTags did have static methods. That might complicate a migration, automated or manual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boot-3.2 recipe Recipe requested
Projects
Status: Recipes Wanted
Development

No branches or pull requests

2 participants