Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop HasSourcePath in favor of FindSourceFiles #3755

Closed
3 tasks done
timtebeek opened this issue Dec 2, 2023 · 1 comment · Fixed by #3758
Closed
3 tasks done

Drop HasSourcePath in favor of FindSourceFiles #3755

timtebeek opened this issue Dec 2, 2023 · 1 comment · Fixed by #3758
Assignees
Labels
enhancement New feature or request

Comments

@timtebeek
Copy link
Contributor

timtebeek commented Dec 2, 2023

What problem are you trying to solve?

Both recipes do the same in slightly different ways; rather than maintain both we want to only have one going forward.
Logging here, but should also be updated downstream.

Describe the solution you'd like

HasSourcePath fully removed, here and downstream, where it can be replaced with FindSourceFiles.

  • Evaluate if any downstream projects use the HasSourcePath regex option, and if so add that to FindSourceFiles.
  • Replace HasSourcePath with FindSourceFiles downstream.
  • Remove HasSourcePath here.

Additional context

@timtebeek
Copy link
Contributor Author

Turns out HasSourcePath supported {.md,.txt} syntax, which FindSourceFiles does not (yet) support. Worked around this in downstream projects where we saw test failures; did not spot this elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant