org.openrewrite.properties.ChangePropertyValue not available?

[Evodam]

I tried to change a property's value according to https://docs.openrewrite.org/recipes/properties/changepropertyvalue

I created a rewrite.yml that contained this:

type: specs.openrewrite.org/v1beta/recipe
name: com.yourorg.ChangeOracleJdbc
displayName: Swap old groupId of com.oracle.jdbc with newer com.oracle.database.jdbc
recipeList:
  - org.openrewrite.properties.ChangePropertyValue:
      propertyKey: oracle.connector.version
      newValue: 21.6.0.0.1
  - org.openrewrite.maven.ChangeManagedDependencyGroupIdAndArtifactId:
      oldGroupId: com.oracle.jdbc
      oldArtifactId: ojdbc8
      newGroupId: com.oracle.database.jdbc
      newArtifactId: ojdbc11
  - org.openrewrite.maven.ChangeDependencyGroupIdAndArtifactId:
      oldGroupId: com.oracle.jdbc
      oldArtifactId: ojdbc8
      newGroupId: com.oracle.database.jdbc
      newArtifactId: ojdbc11

I ran it using mvn org.openrewrite.maven:rewrite-maven-plugin:run -Drewrite.activeRecipes=com.yourorg.ChangeOracleJdbc

In console this recipe is not executed:

When changing the recipe to "org.openrewrite.maven.ChangePropertyValue" it works:

Am I using it wrong?

[timtebeek]

Hi @Evodam ; it's not immediately clear what type of property you're trying to replace.

org.openrewrite.properties.ChangePropertyValue is meant to replace properties in application.properties files, or other files ending in .properties.

rewrite/rewrite-properties/src/main/java/org/openrewrite/properties/PropertiesParser.java

Lines 283 to 286 in dae7728

	@Override
	public boolean accept(Path path) {
	return path.toString().endsWith(".properties");
	}

org.openrewrite.maven.ChangePropertyValue is meant to replace properties in Maven pom.xml and .pom files.

rewrite/rewrite-maven/src/main/java/org/openrewrite/maven/MavenParser.java

Lines 165 to 168 in dae7728

	@Override
	public boolean accept(Path path) {
	return "pom.xml".equals(path.toString()) || path.toString().endsWith(".pom");
	}

From your screenshots it seems you're expecting to replace properties in a pom.xml file; correct? Then you'd want to use the Maven ChangePropertyValue recipe.

If I misunderstood please let me know!

[Evodam]

🤦
Yes, I want to change properties of a pom file. Thanks for clarification. Maybe add a note or something in the documentation?

[timtebeek]

Good to have that cleared up! The hint was in the package names. Open to suggestions what kind of note would have helped here. :)

[Evodam]

@timtebeek

I think something like your comment would have helped.

"This recipe is meant to replace properties in application.properties files, or other files ending in .properties. For changing maven or gradle properties check $link"