Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemoveRedundantDependencyVersions - adding onlyIfManagedVersionIs o… #4148

Merged
merged 5 commits into from
May 21, 2024

Conversation

nmck257
Copy link
Collaborator

@nmck257 nmck257 commented Apr 23, 2024

…ption and deprecating onlyIfVersionsMatch

What's changed?

see title

What's your motivation?

Closes #4138

Anything in particular you'd like reviewers to focus on?

  • Open to alternative designs for the new argument
  • I can just remove the deprecated bits immediately if preferred
  • Not sure if the pseudo-enum is desirable

Anyone you would like to review specifically?

@sambsnyd had made the previous change which this PR is in response to

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

…ption and deprecating `onlyIfVersionsMatch`
@timtebeek timtebeek requested a review from sambsnyd April 23, 2024 19:23
@timtebeek timtebeek added the enhancement New feature or request label Apr 23, 2024
@sambsnyd sambsnyd merged commit 38536a9 into main May 21, 2024
1 check passed
@sambsnyd sambsnyd deleted the feature/4138 branch May 21, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

RemoveRedundantDependencyVersions - restore ability to remove newer version pins
4 participants