Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShadeStyles missing some information #37

Closed
ricardomatias opened this issue Mar 1, 2020 · 1 comment
Closed

ShadeStyles missing some information #37

ricardomatias opened this issue Mar 1, 2020 · 1 comment

Comments

@ricardomatias
Copy link
Member

ricardomatias commented Mar 1, 2020

Link

Does not mention:

  • x_modelMatrix
  • x_modelNormalMatrix

Perhaps there could be some examples which make use of one of the preprocessors and vertexTransform.

@hamoid
Copy link
Member

hamoid commented Mar 14, 2020

More issues based on https://github.com/openrndr/openrndr/blob/master/openrndr-gl3/src/main/kotlin/org/openrndr/internal/gl3/ShaderGeneratorsGL3.kt

  • u_viewMatrix is repeated. remove first one?
  • va_position remove?
  • va_normal remove?
  • va_texCoord0 add?
  • x_modelMatrix = u_modelMatrix; add?
  • x_modelNormalMatrix = u_modelNormalMatrix; add?
  • x_viewMatrix remove?
  • x_viewNormalMatrix = u_viewNormalMatrix; add?
  • c_boundsPosition add?
  • c_boundsSize add?

Also missing:

  • v_worldNormal;
  • v_viewNormal;
  • v_worldPosition;
  • v_viewPosition;
  • v_clipPosition;
  • v_modelNormalMatrix;

Shouldn't these be all va_ instead? They are varyings.

Also, if it's likely to be out-of-date maybe there could be a link to

where one can check the true thing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants