Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color-scheme preference for scale marker #1328

Closed
korpx opened this issue Apr 27, 2015 · 6 comments
Closed

Add color-scheme preference for scale marker #1328

korpx opened this issue Apr 27, 2015 · 6 comments

Comments

@korpx
Copy link
Sponsor

korpx commented Apr 27, 2015

Add preference for the color of the scale markers in color-schemes json-files

@korpx korpx changed the title Option color-scheme preference for scale marker Add color-scheme preference for scale marker Apr 27, 2015
@kintel
Copy link
Member

kintel commented May 4, 2015

FYI: Currently, the axis color is calculated from the background color using ColorMap:: getContrastColor().

@erinzm
Copy link
Contributor

erinzm commented May 12, 2015

Just checking, but I'm assuming that the axis rendering you're talking about is in GLView.cc, and the colour is set around here?

@t-paul
Copy link
Member

t-paul commented May 12, 2015

Yes, that's where the color is calculated (and later used for the axis/scales and the letters from the small axis).

@kintel
Copy link
Member

kintel commented May 15, 2015

Fixed by #1338

@kintel kintel closed this as completed May 15, 2015
@korpx
Copy link
Sponsor Author

korpx commented Oct 19, 2015

axes-color worked fine in 2015.09.03 but has no effect in 2015.10.17
https://github.com/openscad/openscad/blob/master/color-schemes/render/tomorrow-night.json

@kintel
Copy link
Member

kintel commented Oct 19, 2015

It's because the latest compiled snapshot is a release candidate of 2015.03-2, which didn't get this feature backported. Will be fixed once we get 2015.03-2 out the door.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants