Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizer: Don't scan for parameters in included files #1840

Closed
kintel opened this issue Oct 29, 2016 · 3 comments · Fixed by #2322
Closed

Customizer: Don't scan for parameters in included files #1840

kintel opened this issue Oct 29, 2016 · 3 comments · Fixed by #2322

Comments

@kintel
Copy link
Member

kintel commented Oct 29, 2016

Fix handling of includes, those should not be scanned for parameters (see forum post)

(moved from #1781)

@amarjeetkapoor1
Copy link
Member

Any idea on how to solve this issue. Only solution that is coming to my mind is that we keep the name of file like the location is stored for each node (might be usefull for long run) or simply store a boolean to tell whether its from from included file or not to make customizer behave like that of Thingiverse. Otherwise, The behavior is somewhat correct (50%) as it's meant to behave like if part of main file.

@MichaelPFrey
Copy link
Member

Currently, parameters from includes get either no or the wrong description:

error

tricky situation

@amarjeetkapoor1
Copy link
Member

#2044 Could solve this BUT there is a problem attached.
Which would be solved easily by increasing stack size that wouldn't be a viable solution but not good one and another one would require some extra work.

@t-paul t-paul moved this from TODO - Required to Done in OpenSCAD Next Release Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants