Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync top level cmake setup with qmake build. #2518

Closed
7 of 17 tasks
t-paul opened this issue Oct 13, 2018 · 2 comments
Closed
7 of 17 tasks

Sync top level cmake setup with qmake build. #2518

t-paul opened this issue Oct 13, 2018 · 2 comments
Labels
Comp: Build system Tweaks for the build systems / CI integration Type: Maintenance
Projects
Next Release

Comments

@t-paul
Copy link
Member

t-paul commented Oct 13, 2018 •
edited

The qmake build is still the official one, but we do want to move to full cmake build eventually. So this issue is here as reminder to re-sync.

  • Update build documentation
    • readme
    • wikibooks
  • Update for the changes the inputdriver branch brought in
  • Enable HIDAPI support (see Enable HIDAPI for cmake build. #3720)
  • Enable spnavd support
  • add option to enable Sparkle on macOS (qmake CONFIG=deploy)
  • fix -DNULLGL=ON
  • fix/update -DHEADLESS=OFF
  • find_library(QT5QSCINTILLA_LIBRARY) missing PATH_SUFFIXES unlike find_path(QT5QSCINTILLA_INCLUDE)
  • find_package(Qt5) missing Multimedia and target_link_libraries(OpenSCAD Qt5::Multimedia)
  • Add double-conversion
  • Add install target (application, color schemes, examples...)
  • Verify behaviour of DEBUG flags as that can have big performance impact (some nubers in Preview performance regression on Linux when built with cmake #2953)
  • Make sure to use plain c++14 not gnu variants (see Building with cgal-5.1 failing #3497)
  • Check winconsole build (see Move to cmake based build for MXE. #3685)
  • Make sure openscad.com is console binary and openscad.exe is gui

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@t-paul t-paul mentioned this issue Oct 13, 2018
Merged
6 tasks
@kintel kintel added the Comp: Build system Tweaks for the build systems / CI integration label Oct 13, 2018
@t-paul t-paul mentioned this issue Oct 24, 2018
Closed
@thehans thehans mentioned this issue Nov 13, 2018
Merged
@t-paul t-paul mentioned this issue May 24, 2019
Closed
@t-paul t-paul mentioned this issue Aug 15, 2019
Closed
@thehans
Copy link
Member

thehans commented Nov 15, 2019

I checked off a couple of the boxes here,

Input driver stuff also works afaik, but I don't use any special input devices to test with.
I'm not sure what the QT5QSCINTILLA_LIBRARY issue is about, but has been working fine for me.
HEADLESS option was also working last time I checked.

I think maybe the only one still relevant is to add install targets.

@t-paul t-paul mentioned this issue Apr 7, 2020
Closed
This was referenced Feb 14, 2021
Closed
Closed
@t-paul t-paul added this to To do (get into master) in Next Release via automation Feb 14, 2021
@t-paul t-paul mentioned this issue Mar 9, 2021
Closed
@t-paul t-paul mentioned this issue May 10, 2021
Closed
@t-paul
Copy link
Member Author

t-paul commented Jan 19, 2022

Closing, snapshot builds are cmake only for a while.

@t-paul t-paul closed this as completed Jan 19, 2022
Next Release automation moved this from To do (get into master) to Ready (pick to branch pending) Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Comp: Build system Tweaks for the build systems / CI integration Type: Maintenance
Projects
Next Release
Ready (pick to branch pending)
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kintel @thehans @t-paul