Closing with one unsaved tab says "Some tabs have unsaved changes"

[jordanbrown0]

... which is a little confusing if you only have one tab (and so don't even have a tab bar visible).

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[ChrisCoxArt]

Technically it is correct English. But it is odd to use the generic plural to refer to a single document.
Right now the code always uses the same message when it encounters the first unsaved document - and does not check the number of tabs open or unsaved. Since the document/tab count is rarely very high, I think we could check all to get a count before posting the dialog.

And right now you're lucky to even get the message ( #3971 ).

[ChrisCoxArt]

Or we could simply change the wording to "One or more documents has unsaved changes" or "Some of your documents have unsaved changes". I'm not sure which would translate best to other languages.

[jordanbrown0]

Yes to all of that.

"Some of your documents ..." has the same problem of being awkward when there's only one document.

My preference would be to handle the one-tab case specially, with "You have unsaved changes" or something like that. I can propose verbiage if desired.

I'm also happy to do the actual work.

[ChrisCoxArt]

I think I've got the code ready, I just need some time to do more testing.