Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider upgrading to Clipper2 #4394

Open
thehans opened this issue Oct 23, 2022 · 2 comments
Open

Consider upgrading to Clipper2 #4394

thehans opened this issue Oct 23, 2022 · 2 comments

Comments

@thehans
Copy link
Member

thehans commented Oct 23, 2022

The author of the Clipper library (sometimes known as "polyclipping"), which we use for 2D booleans and offsets, has released a major update which I think would be worth looking into.
https://github.com/AngusJohnson/Clipper2

Currently we have source files of clipper included into our own project under src/ext/polyclipping. With Clipper2 being in a github repo, I think it would be simpler and cleaner to build as a git submodule instead.

I'm not sure yet how much of the interface has changed, so no idea how large or small of an effort this would be.

@thehans
Copy link
Member Author

thehans commented Oct 23, 2022

There is also a chance that the new version happens to fix some existing issues such as #4393

@nophead
Copy link
Member

nophead commented Oct 23, 2022

I might be wrong but I think that might be a regression. I ran into such problems in the last year maybe and probably in the last release but the 2D system seemed to be solid going way back before then. It took me by surprise when I was just subtracting squares with coincident edges. I am sure I didn't need an overlap in the past when the coordinates are exactly coincident.

@thehans thehans self-assigned this Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants