Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows CI fails to build #5142

Closed
kintel opened this issue May 19, 2024 · 0 comments
Closed

Windows CI fails to build #5142

kintel opened this issue May 19, 2024 · 0 comments

Comments

@kintel
Copy link
Member

kintel commented May 19, 2024

The Windows GitHub action Windows(msys2) Experimental Tests fails to build:

D:/a/openscad/openscad/build/_deps/clipper2-src/CPP/Clipper2Lib/include/clipper2/clipper.core.h:181:22: note: remove the '< >'
cc1plus.exe: all warnings being treated as errors
[2/284] Building CXX object _deps/clipper2-build/CMakeFiles/Clipper2.dir/Clipper2Lib/src/clipper.engine.cpp.obj
FAILED: _deps/clipper2-build/CMakeFiles/Clipper2.dir/Clipper2Lib/src/clipper.engine.cpp.obj 
D:\a\_temp\msys64\ucrt64\bin\c++.exe -DCLIPPER2_MAX_PRECISION=8 -ID:/a/openscad/openscad/build/_deps/clipper2-build -ID:/a/openscad/openscad/build/_deps/clipper2-src/CPP -ID:/a/openscad/openscad/build/_deps/clipper2-src/CPP/Clipper2Lib/include -frounding-math -Wno-attributes -O3 -DNDEBUG -std=c++17 -Wall -Wextra -Wpedantic -Werror -MD -MT _deps/clipper2-build/CMakeFiles/Clipper2.dir/Clipper2Lib/src/clipper.engine.cpp.obj -MF _deps\clipper2-build\CMakeFiles\Clipper2.dir\Clipper2Lib\src\clipper.engine.cpp.obj.d -o _deps/clipper2-build/CMakeFiles/Clipper2.dir/Clipper2Lib/src/clipper.engine.cpp.obj -c D:/a/openscad/openscad/build/_deps/clipper2-src/CPP/Clipper2Lib/src/clipper.engine.cpp
In file included from D:/a/openscad/openscad/build/_deps/clipper2-src/CPP/Clipper2Lib/include/clipper2/clipper.engine.h:22,
                 from D:/a/openscad/openscad/build/_deps/clipper2-src/CPP/Clipper2Lib/src/clipper.engine.cpp:17:
D:/a/openscad/openscad/build/_deps/clipper2-src/CPP/Clipper2Lib/include/clipper2/clipper.core.h:181:22: error: template-id not allowed for constructor in C++20 [-Werror=template-id-cdtor]
  181 |     explicit Point<T>(const Point<T2>& p) { Init(p.x, p.y); }
      |                      ^
D:/a/openscad/openscad/build/_deps/clipper2-src/CPP/Clipper2Lib/include/clipper2/clipper.core.h:181:22: note: remove the '< >'
cc1plus.exe: all warnings being treated as errors

This looks like AngusJohnson/Clipper2#823, and it looks like Manifold pulls an older version of Clipper2.
Opened Manifold issue: elalish/manifold#814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants