Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming a control block removes subscriptions #1313

Open
danyill opened this issue Aug 24, 2023 · 2 comments
Open

Renaming a control block removes subscriptions #1313

danyill opened this issue Aug 24, 2023 · 2 comments

Comments

@danyill
Copy link
Collaborator

danyill commented Aug 24, 2023

Describe the bug

When a control block name is edited in OpenSCD, subscriptions are invalidated.

To Reproduce

Steps to reproduce the behavior:

  1. Carry out subscriptions for GOOSE or Sampled Values.
  2. Edit a control block (e.g. from the Substation screen by clicking on the (R) or (S))
  3. Rename the control block
  4. Go to the subscription editor
  5. See no count against the subscriptions.

Expected behavior

Renaming a control block results in the srcCBName of subscribed ExtRef elements being updated.

Screenshots

  1. Subscription added:

    image

  2. Control block renamed:

    image

  3. After clicking Save, the subscriptions are lost:

    image

  4. I tested this with a GSEControl element but the same is true for a SampledValueControl

Additional context

Here's the file I used for demonstration.

TPMulticastNaming-Test-2Bus-Prot1.zip

fyi @jarradraumati

@trusz
Copy link
Member

trusz commented Aug 28, 2023

The agreed solution was that the wizard takes care of the renaming of references.
If the use-case comes up often we may extract it out to an SCL library

@github-actions
Copy link
Contributor

Hello there,

Thank you for opening this issue! We appreciate your interest in our project.
However, it seems that this issue hasn't had any activity for a while. To ensure that our issue tracker remains organized and efficient, we occasionally review and address stale issues.

If you believe this issue is still relevant and requires attention, please provide any additional context, updates, or details that might help us understand the problem better.
Feel free to continue the conversation here.

If the issue is no longer relevant, you can simply close it. If you're uncertain, you can always reopen it later.

Remember, our project thrives on community contributions, and your input matters. We're here to collaborate and improve.
Thank you for being part of this journey!

@github-actions github-actions bot added the stale label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants