We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the code as follow:
void CameraManipulator::computeHomePosition(const osg::Camera *camera, bool useBoundingBox) { .......... if (camera->getProjectionMatrixAsFrustum(left,right,bottom,top,zNear,zFar)) { **double vertical2 = fabs(right - left) / zNear / 2.; double horizontal2 = fabs(top - bottom) / zNear / 2.;** ........... } .......... }
I think the code of bold should be as follow:
double horizontal2 = fabs(right - left) / zNear / 2.; double vertical2 = fabs(top - bottom) / zNear / 2.;
Names should be exchanged to avoid misunderstandings!Is it because I misunderstood this code?
The text was updated successfully, but these errors were encountered:
Well spotted, it looks like this typo has been sitting there in the code quite some while. For future reference the problem code is:
https://github.com/openscenegraph/OpenSceneGraph/blob/master/src/osgGA/CameraManipulator.cpp#l107
Sorry, something went wrong.
No branches or pull requests
the code as follow:
I think the code of bold should be as follow:
Names should be exchanged to avoid misunderstandings!Is it because I misunderstood this code?
The text was updated successfully, but these errors were encountered: