Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Handler #13

Closed
AHReccese opened this issue Feb 13, 2024 · 4 comments
Closed

CLI Handler #13

AHReccese opened this issue Feb 13, 2024 · 4 comments
Assignees
Milestone

Comments

@AHReccese
Copy link
Member

AHReccese commented Feb 13, 2024

Description

Add CLI options

reserver --name sample_name1 sample_name2 sample_name3 --token=PYPI_TOKEN --test
@AHReccese AHReccese added this to the Reserver v0.2 milestone Feb 13, 2024
@AHReccese AHReccese self-assigned this Feb 13, 2024
@AHReccese
Copy link
Member Author

@sadrasabouri @sepandhaghighi
Hey guys, let me know your comments on the suggested CLI.
also if you have a better idea, please surely let me know, I'm a little bit worried to get PyPI token in the command line(which will be recorded in the bash history)

@sadrasabouri
Copy link
Member

@sadrasabouri @sepandhaghighi Hey guys, let me know your comments on the suggested CLI. also if you have a better idea, please surely let me know, I'm a little bit worried to get PyPI token in the command line(which will be recorded in the bash history)

I had two suggestions:

  • --test is enough as a true/false flag, no need for --test=True
  • Regarding Pypi token, I think it's OK as is. We can also check from user's environment variables.

@AHReccese
Copy link
Member Author

@sadrasabouri Thank you for your comment, I will consider both.

@sepandhaghighi
Copy link
Member

sepandhaghighi commented May 20, 2024

@AHReccese
I understand your concern about the Pypi token in CLI mode, but I don't think it makes sense to use an environmental variable in the CLI! Therefore, I suggest using --token and printing a warning message about it.

My suggestion:

reserver --name sample_name1 sample_name2 sample_name3 --token=PYPI_TOKEN --test

Reference: https://stackoverflow.com/a/32763023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants