Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve missing MAGICC7 message in tests #124

Closed
rgieseke opened this issue Sep 10, 2018 · 3 comments · Fixed by #164
Closed

Improve missing MAGICC7 message in tests #124

rgieseke opened this issue Sep 10, 2018 · 3 comments · Fixed by #164
Assignees

Comments

@rgieseke
Copy link
Member

With MAGICC7 being skipped if not available in the tests, i'm trying to find a more descriptive error message than:

SKIP [5] /Users/robert/Work/pymagicc/tests/test_api.py:27: MAGICC 7 is not available

It would be run if an environment variable pointing to it were set, right?

@znicholls
Copy link
Collaborator

I believe so. That was going to be part of #126 so happy to assign to me?

@rgieseke
Copy link
Member Author

Not sure how this is related to #126 -- i was thinking of saying something like

"No MAGICC7 binary set. See ..." - we should maybe put this somewhere in the docs.

@znicholls
Copy link
Collaborator

Not sure how this is related to #126

As part of that process, I'm going to have to test whether my written SCEN7 files run with MAGICC7. Hence I"ll need to get these messages set up better and sort out the MAGICC7 API (including the docs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants