Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify the radial for a hold #1451

Closed
oobayly opened this issue Sep 27, 2019 · 5 comments · Fixed by #1452
Closed

Add ability to specify the radial for a hold #1451

oobayly opened this issue Sep 27, 2019 · 5 comments · Fixed by #1452
Assignees
Labels
enhancement Notable improvement or expansion upon an EXISTING feature has pull request Add this label when an issue has a PR which will resolve it

Comments

@oobayly
Copy link
Contributor

oobayly commented Sep 27, 2019

As the title suggests, this would allow the player to specify the radial (inbound heading) that the aircraft should use when holding.

The radial option is purely optional, and defaults to the current behaviour if no radial is provided.

WZZ36EX hold abbot 265

Readback: WZZ36EX, hold east of ABBOT on the 265 radial, right turns, 1min legs

@oobayly oobayly self-assigned this Sep 27, 2019
@oobayly oobayly added the enhancement Notable improvement or expansion upon an EXISTING feature label Sep 27, 2019
@oobayly oobayly added the has pull request Add this label when an issue has a PR which will resolve it label Sep 27, 2019
@erikquinn
Copy link
Member

erikquinn commented Sep 27, 2019

The heading should actually be defined by the radial FROM the holding fix, not the inbound heading, when the user inputs it. For example, the phraseology would be:
AAL123, cleared to JAAWY via direct, hold south of JAAWY on the 190 radial, right turns, 10 mile legs, expect further clearance 1305. This would result in him holding to the south of the fix, with an inbound heading of 010.

@erikquinn
Copy link
Member

So your example command actually should yield a hold WEST of ABBOT, with an inbound heading of 085.

@oobayly
Copy link
Contributor Author

oobayly commented Sep 27, 2019

Thanks. As inboundHeading was used internally, I assumed (and we all know what they're related to) that that was how the phraseology was defined.

@erikquinn
Copy link
Member

erikquinn commented Sep 27, 2019

Yep, it uses the inbound heading because that's easier for maths. You can just accept the radial from the user and add pi to store the inhoundHeading (and radians_normalize()).

@oobayly
Copy link
Contributor Author

oobayly commented Sep 27, 2019

Yup, done exactly that and updated the variable/const names to reflect that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Notable improvement or expansion upon an EXISTING feature has pull request Add this label when an issue has a PR which will resolve it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants