Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Airport: KCVG #272

Closed
OceanManFR opened this issue Feb 27, 2017 · 14 comments
Closed

New Airport: KCVG #272

OceanManFR opened this issue Feb 27, 2017 · 14 comments
Assignees
Labels
airport/airline/aircraft Changes to airport/airline/aircraft files feature Addition of a COMPLETELY NEW feature
Milestone

Comments

@OceanManFR
Copy link
Contributor

OceanManFR commented Feb 27, 2017

Description in this pull request.

@OceanManFR OceanManFR changed the title HELP - KCVG (Cincinnati-Northern Kentucky International Airport) HELP - New Airport: KCVG (Cincinnati-Northern Kentucky International Airport) Feb 27, 2017
@OceanManFR OceanManFR changed the title HELP - New Airport: KCVG (Cincinnati-Northern Kentucky International Airport) HELP - New Airport: KCVG Feb 27, 2017
@n8rzz
Copy link
Member

n8rzz commented Feb 27, 2017

@RNGFavorsNoobs if you want to open a PR, we can spin up a release app that will run your code. It'll update after every push. At least then you'll be able to check your work.

@OceanManFR
Copy link
Contributor Author

@n8rzz , I'm nor exactly sure what a PR or a "release app" is, but if it means I can test it for myself, that would be awesome!

@n8rzz
Copy link
Member

n8rzz commented Feb 27, 2017

yeah, open a pull request. Just thinking about it, I'm not sure if we can spin up a review app from a fork. But I'm curious, so lets give it a shot!

@OceanManFR
Copy link
Contributor Author

@n8rzz I've already opened a pull request here.

@n8rzz
Copy link
Member

n8rzz commented Feb 27, 2017

If you head on over to the pull request, you will see a button towards the bottom view deployment. click that and it will open the app, with the code from your branch. 😉

@n8rzz
Copy link
Member

n8rzz commented Feb 27, 2017

... unless there is a failure. like there is now ☹️

@OceanManFR
Copy link
Contributor Author

Was just about to say something, haha.

@n8rzz
Copy link
Member

n8rzz commented Feb 27, 2017

looks like a JSON syntax error somewhere. try throwing the json you've created in here: http://jsonlint.com/ and then fix any lint errors, then re-commit. The app should rebuild on any new commits.

@Fechulo
Copy link
Member

Fechulo commented Feb 27, 2017

Maybe the missing comma on line 3?

@OceanManFR
Copy link
Contributor Author

There were two errors. Fixed and recommitting. Hold on.

@n8rzz
Copy link
Member

n8rzz commented Feb 27, 2017

@RNGFavorsNoobs you can also join our slack channel http://slack.openscope.co/ (and you can be the first to test this little guy)

@OceanManFR
Copy link
Contributor Author

Recommitted and joining the slack.

@OceanManFR OceanManFR mentioned this issue Feb 27, 2017
@erikquinn erikquinn mentioned this issue Feb 27, 2017
8 tasks
@n8rzz n8rzz added airport/airline/aircraft Changes to airport/airline/aircraft files has pull request Add this label when an issue has a PR which will resolve it labels Feb 27, 2017
@n8rzz n8rzz reopened this Feb 28, 2017
@n8rzz
Copy link
Member

n8rzz commented Feb 28, 2017

@RNGFavorsNoobs we will close this once your PR is merged

@OceanManFR
Copy link
Contributor Author

@n8rzz Whoops. : P

@OceanManFR OceanManFR self-assigned this Mar 1, 2017
@OceanManFR OceanManFR added this to the v4.2.0 milestone Mar 1, 2017
@OceanManFR OceanManFR changed the title HELP - New Airport: KCVG New Airport: KCVG Mar 1, 2017
@OceanManFR OceanManFR removed their assignment Mar 1, 2017
@erikquinn erikquinn modified the milestones: v4.4.0, v4.2.0 Apr 9, 2017
@erikquinn erikquinn removed this from the v5.2.0 milestone Jul 1, 2017
@erikquinn erikquinn added the feature Addition of a COMPLETELY NEW feature label Jul 9, 2017
@erikquinn erikquinn added this to the v6.3.0 milestone Jun 11, 2018
@n8rzz n8rzz removed the has pull request Add this label when an issue has a PR which will resolve it label Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airport/airline/aircraft Changes to airport/airline/aircraft files feature Addition of a COMPLETELY NEW feature
Projects
None yet
Development

No branches or pull requests

4 participants