Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract NavigationLibrary to static class and remove FixCollection references #529

Closed
n8rzz opened this issue Jun 19, 2017 · 0 comments
Closed
Assignees
Labels
refactor Code changes that neither fix a defect nor add functionality
Milestone

Comments

@n8rzz
Copy link
Member

n8rzz commented Jun 19, 2017

These two classes should both be static and, as such, the FixCollection references can be removed from the NavigationLibrary

This one is going to be tricky (hence this issue), both classes are used all over the place. The original intend was to pass references to the NavigationLibrary to the classes that needed it, and that worked, but it is getting harder to maintain.

@n8rzz n8rzz added the refactor Code changes that neither fix a defect nor add functionality label Jun 19, 2017
@n8rzz n8rzz added this to the v5.3.0 milestone Jun 19, 2017
@n8rzz n8rzz self-assigned this Jun 19, 2017
@erikquinn erikquinn removed this from the v5.3.0 milestone Aug 4, 2017
@n8rzz n8rzz added this to the v5.9.0 milestone Feb 6, 2018
@n8rzz n8rzz added the has pull request Add this label when an issue has a PR which will resolve it label Feb 6, 2018
@n8rzz n8rzz mentioned this issue Feb 6, 2018
@erikquinn erikquinn modified the milestones: v6.1.0, v6.0.0 Feb 12, 2018
@n8rzz n8rzz removed the has pull request Add this label when an issue has a PR which will resolve it label Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code changes that neither fix a defect nor add functionality
Projects
None yet
Development

No branches or pull requests

2 participants