Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console.warns are displayed continuously on KSEA #695

Closed
n8rzz opened this issue Sep 11, 2017 · 0 comments
Closed

Console.warns are displayed continuously on KSEA #695

n8rzz opened this issue Sep 11, 2017 · 0 comments
Assignees
@sam-irl
Labels
refactor Code changes that neither fix a defect nor add functionality
Milestone
v5.5.0

Comments

@n8rzz
Copy link
Member

n8rzz commented Sep 11, 2017 •
edited

Browser: Chrome

Airport: KSEA

Issue Description

On initial load, observe in the console alternating warnings between requestAnimationFrame taking too long and defined terrain below sea level.

We should not be throwing a console.warn on every render like this which is likely leading to the raf delays.
@n8rzz n8rzz added the BUGFIX Defect of the simulator, airport, or aircraft label Sep 11, 2017
@n8rzz n8rzz added this to the v5.5.0 milestone Sep 11, 2017
@sam-irl sam-irl mentioned this issue Sep 12, 2017
Merged
@sam-irl sam-irl self-assigned this Sep 12, 2017
@sam-irl sam-irl added the has pull request Add this label when an issue has a PR which will resolve it label Sep 12, 2017
@erikquinn erikquinn added refactor Code changes that neither fix a defect nor add functionality and removed BUGFIX Defect of the simulator, airport, or aircraft labels Sep 13, 2017
@n8rzz n8rzz removed the has pull request Add this label when an issue has a PR which will resolve it label Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sam-irl sam-irl

Labels
refactor Code changes that neither fix a defect nor add functionality
Projects
None yet
Milestone
v5.5.0
Development

No branches or pull requests
3 participants
@n8rzz @erikquinn @sam-irl