Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version command #721

Closed
erikquinn opened this issue Sep 22, 2017 · 3 comments
Closed

Remove version command #721

erikquinn opened this issue Sep 22, 2017 · 3 comments
Labels
refactor Code changes that neither fix a defect nor add functionality

Comments

@erikquinn
Copy link
Member

erikquinn commented Sep 22, 2017

The version command is using prop.version, which is no longer maintained, so when it attempts to log the version number, it instead says:

image

The only place the version number is stored now is in package.json, which ends up in layout.hbs and loadingView.hbs. Somehow we should get this command printing the correct version number.

@erikquinn erikquinn added the BUGFIX Defect of the simulator, airport, or aircraft label Sep 22, 2017
@n8rzz
Copy link
Member

n8rzz commented Sep 22, 2017

do we really need this command anymore? I mean we print that information on build within the html:

screen shot 2017-09-22 at 1 54 18 pm

@erikquinn
Copy link
Member Author

I give zero 💩s about the command myself.

@n8rzz
Copy link
Member

n8rzz commented Sep 22, 2017

Oh good, we're on the same page then.

@sam-irl sam-irl mentioned this issue Sep 22, 2017
@erikquinn erikquinn changed the title version command returns undefined version number Remove version command Sep 23, 2017
@erikquinn erikquinn added refactor Code changes that neither fix a defect nor add functionality and removed BUGFIX Defect of the simulator, airport, or aircraft labels Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code changes that neither fix a defect nor add functionality
Projects
None yet
Development

No branches or pull requests

2 participants