Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate GameTime and TimeKeeper #725

Closed
n8rzz opened this issue Sep 25, 2017 · 0 comments
Closed

Consolidate GameTime and TimeKeeper #725

n8rzz opened this issue Sep 25, 2017 · 0 comments
Labels
refactor Code changes that neither fix a defect nor add functionality

Comments

@n8rzz
Copy link
Member

n8rzz commented Sep 25, 2017

We are keeping track of game time in two separate places. There should be a single source of truth for this value and/or a single place to calculate deltaTime.

Currently this is happening within TimeKeeper (which should be the single source of truth) and the GameController which is offsetting TimeKeeper time with #speedup and then storing it's own deltaTime.
@n8rzz n8rzz added the refactor Code changes that neither fix a defect nor add functionality label Sep 25, 2017
This was referenced Sep 26, 2017
Merged
Closed
Merged
@n8rzz n8rzz mentioned this issue Oct 7, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Code changes that neither fix a defect nor add functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@n8rzz