Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create singleton to store pan and scale values #726

Closed
n8rzz opened this issue Sep 25, 2017 · 1 comment
Closed

Create singleton to store pan and scale values #726

n8rzz opened this issue Sep 25, 2017 · 1 comment
Assignees
Labels
enhancement Notable improvement or expansion upon an EXISTING feature
Milestone

Comments

@n8rzz
Copy link
Member

n8rzz commented Sep 25, 2017

The pan values currently live within the CanvasController and the scale value lives within the UiController. This is confusing and should be consolidated.

These values should live within their own class which would provide getters and setters and some translation methods. The classes using these values can then reference the singleton as a single source of truth.

should store:

  • canvas.size.width and canvas.size.height
  • panX and panY
  • scale
@n8rzz n8rzz added enhancement Notable improvement or expansion upon an EXISTING feature BLOCKED Depends upon the resolution of a different issue labels Sep 25, 2017
@n8rzz
Copy link
Member Author

n8rzz commented Sep 25, 2017

work on this should happen after #707 is merged due to the likelihood of massive merge conflicts

@n8rzz n8rzz mentioned this issue Sep 26, 2017
@n8rzz n8rzz self-assigned this Oct 6, 2017
@n8rzz n8rzz added this to the v5.6.0 milestone Oct 6, 2017
@n8rzz n8rzz removed the BLOCKED Depends upon the resolution of a different issue label Oct 13, 2017
@erikquinn erikquinn added the has pull request Add this label when an issue has a PR which will resolve it label Oct 14, 2017
@n8rzz n8rzz removed the has pull request Add this label when an issue has a PR which will resolve it label Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Notable improvement or expansion upon an EXISTING feature
Projects
None yet
Development

No branches or pull requests

2 participants