-
-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when reference strip used with Shadow DOM #1674
Comments
I'm not familiar with working with the shadow DOM, so I guess we'll have to meet in the middle somehow! Would this work?
That way we can stick with the ID structure. |
I'm all for meeting in the middle. Just tested my app, works good |
I solved this by passindg th element instead. THEN
}); BUT |
@PCailly i did the same thing. Passing HTML Elements for |
Closing this...feel free to re-open if issues persist! |
When including a viewer inside a web component (with Shadow DOM), with a reference strip enabled, i get the error:
TypeError: Cannot read property 'style' of null
and the selected thumbnail in the reference strip is not highlightedError Example: https://jsbin.com/beyunawuhu/1/edit?js,output
it looks like this is due to the
$.getElement
call here:openseadragon/src/referencestrip.js
Line 239 in c7aa6ed
would it be possible to do something like this:
$.getElement( this.element.children[page] )
so that it's scoped to the element, instead of the light dom
(sry, im not very familiar with your codebase)
The text was updated successfully, but these errors were encountered: