Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MD]Add client connection in data source plugin #1971

Closed
3 tasks done
Tracked by #2003
zhongnansu opened this issue Jul 27, 2022 · 2 comments
Closed
3 tasks done
Tracked by #2003

[MD]Add client connection in data source plugin #1971

zhongnansu opened this issue Jul 27, 2022 · 2 comments
Assignees
Labels
multiple datasource multiple datasource project

Comments

@zhongnansu zhongnansu added the multiple datasource multiple datasource project label Jul 27, 2022
@zhongnansu zhongnansu changed the title Add OpenSearchDataService in core Add OpenSearchDataService in core(to epic) Jul 27, 2022
@zhongnansu zhongnansu self-assigned this Aug 1, 2022
@zengyan-amazon
Copy link
Member

we will not add OpenSearchDataService to OSD core, instead, I'd make it part of data source plugin. So we will register data source saved object type into dataSource plugin, and provide functions for other components to get OpenSearch client for data sources in request context

@zengyan-amazon zengyan-amazon changed the title Add OpenSearchDataService in core(to epic) Add OpenSearchDataService in OSD Aug 2, 2022
@zhongnansu zhongnansu changed the title Add OpenSearchDataService in OSD Add client connection logic in data source plugin Aug 3, 2022
@zhongnansu zhongnansu changed the title Add client connection logic in data source plugin Add client connection in data source plugin Aug 3, 2022
@seraphjiang seraphjiang changed the title Add client connection in data source plugin [MD]Add client connection in data source plugin Aug 8, 2022
@zhongnansu
Copy link
Member Author

Due to the change of design, we are moving the client management from a "core service" to data source plugin. The most uncertain refactor is how to expose "getDataSourceClient" function in request handler context. The previous idea is proved by POC that we can register it with "core context". But we can't apply the same within a plugin.

I am working on a POC to register "getClient()" interface, to request context from a plugin. It's likely it will be implemented in search plugin, and only be exposed to search plugin. While the actual service can be in data_source plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multiple datasource multiple datasource project
Projects
None yet
Development

No branches or pull requests

2 participants