Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn version incompatible with openearch-js 2.x #3459

Closed
zhongnansu opened this issue Feb 18, 2023 · 1 comment
Closed

yarn version incompatible with openearch-js 2.x #3459

zhongnansu opened this issue Feb 18, 2023 · 1 comment
Labels
build Build related additions or modifications v3.0.0

Comments

@zhongnansu
Copy link
Member

zhongnansu commented Feb 18, 2023 •
edited
Loading

Coming from opensearch-project/opensearch-build#3210

Need to update yarn version in package.json

This issue was not caught in OSD core build CI, I guess the reason is we hardcoded yarn to be 1.22 in github build workflow. https://github.com/opensearch-project/OpenSearch-Dashboards/blame/9124fe80d6dba77a905b7cd36c306aa42a70bf2d/.github/workflows/build_and_test_workflow.yml#L49
Should we get yarn version from OSD package.json, simliar to external plugins CI workflow? @kavilla
@zhongnansu zhongnansu added build Build related additions or modifications untriaged and removed untriaged labels Feb 18, 2023
@zhongnansu zhongnansu mentioned this issue Feb 18, 2023
Merged
8 tasks
@kavilla kavilla added v3.0.0 and removed v2.7.0 labels Feb 24, 2023
@AMoo-Miki
Copy link
Collaborator

This should no longer be a problem. Is it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Build related additions or modifications v3.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@joshuarrrr @AMoo-Miki @kavilla @zhongnansu @abbyhu2000