Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Anywhere] Performance test the new feature anywhere integration across OSD and plugins. #3833

Closed
Tracked by #2880
amitgalitz opened this issue Apr 12, 2023 · 7 comments
Labels

Comments

@amitgalitz
Copy link
Member

We should have metrics we look at to make sure the new feature anywhere doesn't bring any degradation to cluster or current OSD as well as that feature anywhere itself holds to reasonable performance standards. This means testing out the limitations of changing the default number of associated objects per visualizations and any other new UI or visualizations that is part of the feature anywhere project.

@ohltyler
Copy link
Member

We should also test some bulk deletion scenarios. Ref: #4059 (comment)

@kavilla
Copy link
Member

kavilla commented May 31, 2023

As called out: #3981

We will target this for v2.next for prioritization on Node upgrade.

@kavilla kavilla added v2.9.0 and removed v2.8.0 labels May 31, 2023
@joshuarrrr
Copy link
Member

@ohltyler @amitgalitz This is tagged for 2.9 release - is there any remaining work to be done here or updates on progress? Will there be any PRs to review?

@ohltyler
Copy link
Member

This has been in progress - I'll post some comprehensive results here when completed. The initial testing showed some clear bottlenecks and led to 2 big improvements (one included in 2.9)

@ohltyler
Copy link
Member

Results:
Screenshot 2023-07-26 at 1 03 21 PM

@ohltyler
Copy link
Member

ohltyler commented Jul 26, 2023

Conclusions:

  • Overall association count has impact on loading dashboard. On 3-node cluster, 32s increase when processing 0 vs. 1000 associations
  • Overall association count has impact on loading view events flyout. On 3-node cluster, 25s increase when processing 1 vs. 100 associations
  • Loading time for view events flyout scales linearly. This make sense, since each visualization rendered in the flyout is executed sequentially, and rendered all at once when all of them have been created / render workflow completed. An improvement can be done to have these done asynchronously similar to a dashboard.
  • No load issues in plugin flyouts regardless of overall association count
  • Event count & time range had little to no effect. For example, rendering a vis with 500 events had the identical load times compared to rendering the same vis with 0 events. This shows that event fetching / event processing / bucketing / rendering of event datapoints scales fine. It makes sense since there is a fixed number of datapoints shown on the vega charts.
  • Vis count did not have a huge effect. Since visualizations are rendered async on a dashboard, the overall count didn't have drastic impact. There was a noticeable effect however, as the vis count increased to something like 20+ visualizations. For example, it took roughly double the time for a dashboard with 20 visualizations (each with 50 associations) to load (39s), than for a dashboard with 1 visualization with 50 associations (18s).

@ohltyler
Copy link
Member

ohltyler commented Jul 26, 2023

Next steps:

Finished:

To do (optimizing client-side logic):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants