Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][Data explorer] Whole page reloads when opening saved search #5066

Closed
joshuali925 opened this issue Sep 19, 2023 · 3 comments · Fixed by #5168
Closed

[BUG][Data explorer] Whole page reloads when opening saved search #5066

joshuali925 opened this issue Sep 19, 2023 · 3 comments · Fixed by #5168
Assignees
Labels
bug Something isn't working data explorer Issues related to the Data Explorer project de-angular de-angularize work discover for discover reinvent v2.11.0

Comments

@joshuali925
Copy link
Member

Describe the bug

When opening a saved search in the new discover, the page reloads with opensearch logo and text Loading OpenSearch Dashboards. This behavior is disturbing and doesn't happen in old discover

To Reproduce
Steps to reproduce the behavior:

  1. Go to new discover
  2. Click on save, save
  3. Open the saved search
  4. See whole page loading

Expected behavior
Page should update directly without loading logo/text, like old discover

OpenSearch Version
main

Dashboards Version
main

Plugins

no plugins

Screenshots

If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Browser and version [e.g. 22]

Additional context

Add any other context about the problem here.

@joshuali925 joshuali925 added bug Something isn't working untriaged labels Sep 19, 2023
@abbyhu2000 abbyhu2000 added data explorer Issues related to the Data Explorer project and removed untriaged labels Sep 26, 2023
@abbyhu2000
Copy link
Member

@joshuali925 This is the expected way of how save search works in data explorer currently. Do we have plans to fix this? @ashwin-pc

@joshuali925
Copy link
Member Author

any technical limitation making it expected behavior? it seems like a regression from old discover

@kavilla
Copy link
Member

kavilla commented Sep 26, 2023

any technical limitation making it expected behavior? it seems like a regression from old discover

Without looking deeply and @abbyhu2000 tell me if I'm wrong. The angular wrapper would basically treat navigating from the React app to the Angular parts of the card as a new location and was forcing a refresh. Now it could be that the application doesn't have to completely reload when navigating between the parts of the application and the Discover there can be a bad data state with existing behavior from Discover. Since Discover (and the Dashboard plugin) was built benefiting off this implementation and assumed that they did not have to care about a previous render state when in angular

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data explorer Issues related to the Data Explorer project de-angular de-angularize work discover for discover reinvent v2.11.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants