Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Creating datasource breaks saved objects table #6289

Open
derek-ho opened this issue Mar 28, 2024 · 8 comments
Open

[BUG] Creating datasource breaks saved objects table #6289

derek-ho opened this issue Mar 28, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@derek-ho
Copy link
Contributor

derek-ho commented Mar 28, 2024

Describe the bug

Create a new datasource within a custom tenant, then visit the saved objects table, the page crashes (when security plugin is installed and viewable).

Screenshot 2024-03-28 at 11 24 26 AM

Seems like there is an issue with extracting the namespace field from the datasource saved object
Screenshot 2024-03-28 at 11 27 30 AM

@derek-ho derek-ho added bug Something isn't working untriaged labels Mar 28, 2024
@derek-ho
Copy link
Contributor Author

derek-ho commented Mar 28, 2024

Looks like data source namespace should be structured something like:

[["XXX"]]

Instead of not existing as a property

@derek-ho
Copy link
Contributor Author

derek-ho commented Mar 28, 2024

Looks like the util function actually lives inside security-dashboards plugin repo. We may need to make the change there if it involves data migration issues - https://github.com/opensearch-project/security-dashboards-plugin/blob/main/public/apps/configuration/utils/tenant-utils.tsx#L217

@derek-ho
Copy link
Contributor Author

Update this seems to be a bug with storing datasources with aggregation view experimental feature enabled in the security plugin CC @cwperks

@kavilla
Copy link
Member

kavilla commented Apr 2, 2024

@BionIT @cwperks

Do you guys mind commenting on this? And untriaging if you are working on this?

@cliu123
Copy link
Member

cliu123 commented Apr 2, 2024

The value of namespaces field of a saved object is undefined, which could not be flatten by flat() method in this case. I'd suggest to move the issue to security-dashboards-plugin for reproduction and investigation.

@cwperks
Copy link
Member

cwperks commented Apr 2, 2024

The aggregation view for security-dashboards-plugin was an experimental feature that was a precursor to workspaces that was not launched GA. It was an effort with multi-tenancy to make sharing saved objects between tenants easier, but multi-tenancy is being replaced by workspaces so the effort was discontinued.

This bug is only present when the aggregation view feature is enabled: opensearch_security.multitenancy.enable_aggregation_view: true

@BionIT
Copy link
Collaborator

BionIT commented Apr 2, 2024

Looks like this is an issue for security dashboard plugin, can we transfer this issue to security dashboards repo? @cwperks @derek-ho

@seraphjiang
Copy link
Member

The value of namespaces field of a saved object is undefined, which could not be flatten by flat() method in this case. I'd suggest to move the issue to security-dashboards-plugin for reproduction and investigation.

would you help to move the issue @opensearch-project/admin to security-dashboards-plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants