Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OE] plugins should support the root level config enabled #6304

Open
kavilla opened this issue Apr 2, 2024 · 0 comments
Open

[OE] plugins should support the root level config enabled #6304

kavilla opened this issue Apr 2, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers operational excellence

Comments

@kavilla
Copy link
Member

kavilla commented Apr 2, 2024

Is your feature request related to a problem? Please describe.

Plugins have the ability to add enabled at the top level of their config which would then allow for the cluster admin to disable the plugin scale up the application and the files would not even be uploaded to the server to be discoverable

However, some plugins have custom logic to make it appear that they are disabled. But the files are still uploaded into the server to be discoverable.

This could cause issues that this fail-safe can easily solve.

  • If a plugin is not compatible, it would break the start up process until the admin uninstall the plugin.
  • If a plugin contains security issues, we can not use the fail safe to reliable remove the vulnerability files
  • If a plugin is experimental, then we do not have to worry about failures.

Example:
https://github.com/opensearch-project/dashboards-assistant/blob/main/common/types/config.ts#L10

Describe the solution you'd like

Audit https://github.com/opensearch-project plugins for OpenSearch Dashboards and verify they properly used the enabled config.

If so, create an issue in their repo (potentially make the change). Track it apart of this issue.

Describe alternatives you've considered

n/a

Additional context

Likely will need to update the available docker vars within the build repo to allow those configurations to be set with docker.

@kavilla kavilla added the enhancement New feature or request label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers operational excellence
Projects
None yet
Development

No branches or pull requests

1 participant