Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Hide local cluster should be set using yaml config #6336

Closed
Tracked by #5872
BionIT opened this issue Apr 3, 2024 · 2 comments
Closed
Tracked by #5872

[BUG] Hide local cluster should be set using yaml config #6336

BionIT opened this issue Apr 3, 2024 · 2 comments
Assignees
Labels
bug Something isn't working multiple datasource multiple datasource project v2.14.0

Comments

@BionIT
Copy link
Collaborator

BionIT commented Apr 3, 2024

Describe the bug
In #5754, we introduced a new yaml config to allow hide local cluster from the data source component. This property is needed for the component to decide if local cluster should be shown as an option.

Note that this property should be set from the yaml config, note that we can get the prop from the dataSource object https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/data_source/public/types.ts#L8 and should set it in https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/data_source_management/public/plugin.ts#L105

Additional context

Add any other context about the problem here.

@BionIT BionIT added bug Something isn't working untriaged v2.14.0 multiple datasource multiple datasource project labels Apr 3, 2024
@zhongnansu
Copy link
Member

Hi Lu @BionIT, I'd like to work on this issue

@zhongnansu zhongnansu self-assigned this Apr 3, 2024
@BionIT
Copy link
Collaborator Author

BionIT commented Apr 3, 2024

Awesome, thanks @zhongnansu !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working multiple datasource multiple datasource project v2.14.0
Projects
Status: No status
Development

No branches or pull requests

2 participants