Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Action Required] Ensure 2.11 branch readiness for 2.11.1 release #11094

Closed
2 tasks
gaiksaya opened this issue Nov 4, 2023 · 2 comments
Closed
2 tasks

[Action Required] Ensure 2.11 branch readiness for 2.11.1 release #11094

gaiksaya opened this issue Nov 4, 2023 · 2 comments
Labels
v2.11.1 Issues targeting release v2.11.1

Comments

@gaiksaya
Copy link
Member

gaiksaya commented Nov 4, 2023

Coming from opensearch-project/opensearch-build#4161

What is happening?

We are planning 2.11.1 release in upcoming few weeks. Following the semver guildelines and branching strategy, this release will be based on 2.11 as a reference branch

Why?

  1. We need this release because of a critical breaking bug in the security plug-in. This bug impacts everyone using logstash and the only work around is to turn off compression (which is expensive)

  2. As a refresher, our normal process is to commit changes to main, then backport to 2.x. Since the 1.0 release, we only backport bug fixes and security changes to the current 2.x branch (in this case 2.11) so that if we need to we can quickly do a patch release.

  3. There are two reason we don’t back port features to the current release branch (right now 2.11):

    1. Because we want patch release to be as thin as possible, and the more changes you make, the more verification we need to do
    2. Adding features in a patch breaks semver.

However, looking at the list of changes for 2.11, we currently have a mix of features that have been merged in. After providing several options and discussing with all the component teams as well as community we came to the conclusion of reverting all feature related changes from 2.11 branch.

What do I need to do?

Please help revert all the commits that are related to new features or enhancements from 2.11 branch that were added after 2.11.0 release.
Here is a rough list of commits that went in after 2.11.0 release for each repo.

Status

Please check-mark one of the below and close this issue once the action item is completed.

  • We confirm that no features or enhancements were added to 2.11 branch. We are good to go for 2.11.1 consisting only of bug fixes and security fixes.

OR

  • We have reverted all the feature or ehancement related commits from 2.11 branch. We are good to go for 2.11.1 consisting only of bug fixes and security fixes.

Thank you!
cc: @bbarani @CEHENKLE @Divyaasm

@gaiksaya gaiksaya added bug Something isn't working untriaged v2.11.1 Issues targeting release v2.11.1 and removed bug Something isn't working labels Nov 4, 2023
@reta
Copy link
Collaborator

reta commented Nov 6, 2023

There are 3 changes merged in 2.11 that I think are legitimate and should not be reverted:

I believe OpenSearch core for 2.11.1 is a good shape and does not require any reverts.

@bowenlan-amzn
Copy link
Member

We confirm that no features or enhancements were added to 2.11 branch. We are good to go for 2.11.1 consisting only of bug fixes and security fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.11.1 Issues targeting release v2.11.1
Projects
None yet
Development

No branches or pull requests

3 participants